From 65375bc34dd7e082331cbccc0299c6a99fea28ce Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Tue, 25 Jun 2024 15:01:29 -0300 Subject: [PATCH] Bug 37182: Make Koha::Statistic->new preserve 'datetime' if passed This patch does what the title says. This behavior is tested on the previous patch. Tests are also added for the background job (which relies on Koha::Statistic->new and was the evidence of this overwrite behavior). To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Statistic.t \ t/db_dependent/Koha/BackgroundJob/PseudonymizeStatistic.t => FAIL: Tests don't pass :-/ 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer --- Koha/Statistic.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Koha/Statistic.pm b/Koha/Statistic.pm index 0eb7414c46..14f299569f 100644 --- a/Koha/Statistic.pm +++ b/Koha/Statistic.pm @@ -90,7 +90,7 @@ sub new { my @missing = map { exists $params->{$_} ? () : $_ } @mandatory_keys; Koha::Exceptions::MissingParameter->throw( parameter => join( ',', @missing ) ) if @missing; - my $datetime = Koha::Database->new->schema->storage->datetime_parser->format_datetime( dt_from_string() ); + my $datetime = $params->{datetime} ? $params->{datetime} : dt_from_string(); return $class->SUPER::new( { borrowernumber => $params->{borrowernumber}, # no longer sending empty string (changed 2023) -- 2.39.5