From 9371685b973a287b7642fb907721f4964d92e65a Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Thu, 13 Aug 2020 13:19:19 +0000
Subject: [PATCH] Bug 26202: Remove the use of jquery.checkboxes plugin from
 batch record modification page

This patch removes the use of the jquery.checkboxes plugin from the
batch record modification page.

To test, apply the patch and go to Tools -> Batch record modification

 - Submit a batch of biblionumbers for modification.
 - On the results page, test the "Select all" and "Clear all" links to
   confirm that they work correctly.

Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 .../modules/tools/batch_record_modification.tt   | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
index 66de6f4b1c..19aab275b5 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
@@ -302,7 +302,6 @@
 [% MACRO jsinclude BLOCK %]
     [% Asset.js("js/tools-menu.js") | $raw %]
     [% INCLUDE 'datatables.inc' %]
-    [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %]
     [% Asset.js("lib/jquery/plugins/humanmsg.js") | $raw %]
     [% Asset.js("js/background-job-progressbar.js") | $raw %]
     <script>
@@ -317,14 +316,21 @@
                     $("#show_list_option").show();
                 }
             });
-            $("#selectall").click(function(e) {
+
+            $("#selectall").click(function(e){
                 e.preventDefault();
-                $(".records").checkCheckboxes();
+                $(".records input[type='checkbox']").each(function(){
+                    $(this).prop("checked", true);
+                });
             });
-            $("#clearall").click(function(e) {
+
+            $("#clearall").click(function(e){
                 e.preventDefault();
-                $(".records").unCheckCheckboxes();
+                $(".records input[type='checkbox']").each(function(){
+                    $(this).prop("checked", false);
+                });
             });
+
             $("#selectall").click();
 
             $("table#biblios").dataTable($.extend(true, {}, dataTablesDefaults, {
-- 
2.39.5