From a66b6cda96fe38a051c2274356015cb3eae0028b Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Thu, 16 Dec 2021 13:16:15 +0100
Subject: [PATCH] Bug 29648: Holds history - no sort

because of desc

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 admin/columns_settings.yml                                  | 1 +
 .../intranet-tmpl/prog/en/modules/members/holdshistory.tt   | 6 +++---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml
index 78b14a3106..e76ff5ca7b 100644
--- a/admin/columns_settings.yml
+++ b/admin/columns_settings.yml
@@ -922,6 +922,7 @@ modules:
 
     holdshistory:
       holdshistory-table:
+        default_display_length: 20
         columns:
             -
               columnname: title
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt
index eee0eb3239..0fdff2c1b6 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt
@@ -137,15 +137,15 @@
     [% Asset.js("js/members-menu.js") | $raw %]
     <script>
         $(document).ready(function() {
-            var columns_settings = [% TablesSettings.GetColumns('members', 'holdshistory', 'holdshistory-table', 'json') %];
+            var table_settings = [% TablesSettings.GetTableSettings('members', 'holdshistory', 'holdshistory-table', 'json') %];
             [% UNLESS show_itemtype_column %]
               //Remove item type column settings
-              columns_settings = columns_settings.filter(function(c){return c['columnname'] != 'itemtype';});
+              table_settings['columns'] = table_settings['columns'].filter(function(c){return c['columnname'] != 'itemtype';});
             [% END %]
             var table = KohaTable("table_holdshistory", {
                 "sPaginationType": "full",
                 "aaSorting": [[4, 'desc']]
-            }, columns_settings);
+            }, table_settings);
         });
     </script>
 [% END %]
-- 
2.39.5