From ad619e2dc3e012e6b54e79ee92577f0730ba01cc Mon Sep 17 00:00:00 2001
From: Katrin Fischer <katrin.fischer.83@web.de>
Date: Sun, 24 May 2020 02:04:03 +0200
Subject: [PATCH] Bug 25443: Improve translation of 'Select the record to
 link%s to'

Before this patch the title was set in italic, which caused the
translation string to be cut off. Removing the italic formatting in
favor of quotes and splitting the string into 2 sentences (dealing
with title existing and not existing:

Select the host record to link to '[% bibliotitle | html %]'
Select the host record to link

To test:
- Activate EasyAnalyticalRecords system preference
- Search for a record in staff
- Use Edit > Link to host record
- Verify the text is shown as above with the reord's title
- The second case is a bit theoretical:
- Delete 245$a from the record or empty out biblio.title using SQL
- Verify the string still shows but without the 'to...' part.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit d53b58cab858f06be7f9762b16b89c8bfbce5625)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit f7b93ef9c54bd1ce662ff7147f958a6fa73369a2)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
---
 .../intranet-tmpl/prog/en/modules/cataloguing/linkitem.tt | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/linkitem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/linkitem.tt
index 84200afb45..0d5e51cb39 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/linkitem.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/linkitem.tt
@@ -42,7 +42,13 @@
 
     	    [% IF ( missingbarcode ) %]
 	    <fieldset id="barcode_fieldset">
-        <label for="barcode_fieldset">Select the host record to link[% IF ( bibliotitle ) %] to <i>[% bibliotitle | html %]</i>[% END %]</label>
+        <label for="barcode_fieldset">
+            [% IF (bibliotitle ) %]
+                Select the host record to link to '[% bibliotitle | html %]'
+            [% ELSE %]
+                Select the host record to link
+            [% END %]
+        </label>
 		    <div class="hint">Enter item barcode:</div>
 		    <input type="text" name="barcode" id="barcode" class="barcode focus" size="14" /> 
 	    </fieldset>
-- 
2.39.5