From 7523e7f7fc033045f29fba24eed0f9b53bf09599 Mon Sep 17 00:00:00 2001 From: Blou Date: Fri, 24 Aug 2018 11:46:54 -0400 Subject: [PATCH] Bug 21270: "Not finding what you're looking for" displaying uselessly MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit When doing OPAC search, at the bottom you have an offer presented with "Not finding what you're looking for" to introduce Suggestions or ILL if enabled. Bug 7317 modified the if-else and now if you enable ILLModule but not AnonSuggestions and are not logged, you have this little string sitting there, offering nothing to the user. Just taunting them... TEST: 0) Set IllModule to true, AnonSuggestions to false. 1) Without login, just to an OPAC search. At the bottom will be a nice string laughing at your failed search 2) Apply the patch. 3) Problem at 1) is fixed. 4) Login to validate that ILL link now appear. 5) Modify combination of IllModule and AnonSuggestions to validate links appearing. Signed-off-by: Dilan Johnpullé Signed-off-by: Andrew Isherwood Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 489cfb4b19b72dc1b156b0a4fa38add79ee3f05b) Signed-off-by: Lucas Gass (cherry picked from commit c3c0a1228f134df0a5bc0a2f692310c3451a88b8) Signed-off-by: Hayley Mapley --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt index c256a814c2..68b1e2f861 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt @@ -575,7 +575,7 @@ [% END # / IF total %] - [% IF Koha.Preference( 'suggestion' ) == 1 && ( Koha.Preference( 'AnonSuggestions' ) == 1 || loggedinusername || Koha.Preference( 'ILLModule' ) == 1 ) %] + [% IF Koha.Preference( 'suggestion' ) == 1 && ( Koha.Preference( 'AnonSuggestions' ) == 1 || loggedinusername ) %]
Not finding what you're looking for?
    -- 2.39.5