]> git.koha-community.org Git - koha.git/commit
Bug 34041: (follow-up) escape double dashes to prevent issues
authorTomas Cohen Arazi <tomascohen@theke.io>
Fri, 10 May 2024 12:30:53 +0000 (09:30 -0300)
committerLucas Gass <lucas@bywatersolutions.com>
Thu, 30 May 2024 19:07:54 +0000 (19:07 +0000)
commit8fb97b9b26351a55d0fa494c4904288a9d57902f
tree388c1c8844d87d8d80f78d4e802d2a0b289926e1
parentb614b7d7b67bd5a0c6cd9fff0a6ba51622bde9c4
Bug 34041: (follow-up) escape double dashes to prevent issues

Having double dashes inside a commmented block is not valid XML. This
patch restores it, with an added message explaining it

To test:
1. Run:
   $ xmllint etc/z3950/config.xml
=> FAIL: You get:
etc/z3950/config.xml:5: parser error : Double hyphen within comment: <!--
  <config>
      <z3950_responder_options>
      <z3950_responder_options>--add-item-status k -t 5</z3950_responder_options
2. Apply this patch
3. Repeat 1
=> SUCCESS: All good!

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 11c69496bcd216ad264acd87409e5160c73995bf)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit afb9cd8e1ccf941ae8cf6e1070dd41a285dcb86b)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
etc/z3950/config.xml