From f745ba2bc7c3450e744416cf9692ed399528bcdc Mon Sep 17 00:00:00 2001
From: Julian Maurice <julian.maurice@biblibre.com>
Date: Wed, 18 Apr 2018 15:20:02 +0200
Subject: [PATCH] Bug 20343: Put translatable strings in strings.tt

Also add a CSS class on <details> for easier styling and change the
list style so it take less space on screen

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 618ccd243ea9bdd2daa115415bafb5a4c864333b)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 koha-tmpl/intranet-tmpl/prog/css/staff-global.css    | 5 +++++
 koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc | 2 ++
 koha-tmpl/intranet-tmpl/prog/js/checkouts.js         | 5 +++--
 3 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/css/staff-global.css
index 76f8056d25..12a87a0121 100644
--- a/koha-tmpl/intranet-tmpl/prog/css/staff-global.css
+++ b/koha-tmpl/intranet-tmpl/prog/css/staff-global.css
@@ -1093,6 +1093,11 @@ span.expired {
 	font-style : italic;
 }
 
+details.checkouts-by-itemtype li {
+    display: inline-block;
+    margin-right: 1em;
+}
+
 div.help {
 	margin: .9em 0 0 0;  
 }
diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc
index e116204cdc..e7c68d751c 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc
@@ -43,5 +43,7 @@
     var SUSPEND_HOLD_ERROR_NOT_FOUND = _("Unable to suspend hold, hold not found");
     var RESUME_HOLD_ERROR_NOT_FOUND = _("Unable to resume, hold not found");
     var CURRENT = _(" (current) ");
+    var MSG_NO_ITEMTYPE = _("No itemtype");
+    var MSG_CHECKOUTS_BY_ITEMTYPE = _("Number of checkouts by item type");
 //]]>
 </script>
diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
index 7d106cad2a..5c9f047f71 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
+++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
@@ -497,12 +497,13 @@ $(document).ready(function() {
                 var ul = $('<ul>');
                 Object.keys(checkoutsByItype).sort().forEach(function (itype) {
                     var li = $('<li>')
-                        .append($('<strong>').html(itype || _("No itemtype")))
+                        .append($('<strong>').html(itype || MSG_NO_ITEMTYPE))
                         .append(': ' + checkoutsByItype[itype]);
                     ul.append(li);
                 })
                 $('<details>')
-                    .append($('<summary>').html(_("Number of checkouts by item type")))
+                    .addClass('checkouts-by-itemtype')
+                    .append($('<summary>').html(MSG_CHECKOUTS_BY_ITEMTYPE))
                     .append(ul)
                     .insertBefore(oSettings.nTableWrapper)
             },
-- 
2.39.5