]> git.koha-community.org Git - koha.git/commit
Bug 19766: (bug 19058 follow-up) Fix Preview routing slip
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 6 Dec 2017 19:33:56 +0000 (16:33 -0300)
committerNick Clemens <nick@bywatersolutions.com>
Wed, 13 Dec 2017 17:42:24 +0000 (12:42 -0500)
commit5a458a6e771f4d4675f3c99cd04dae0a387e1fd8
tree3b0c91a84b370c3f6c5835ca94c86021396f7895
parent2b74d72a2d72f2be1361d3d223c403b992c80fab
Bug 19766: (bug 19058 follow-up) Fix Preview routing slip

This patch fixes the following errors:
The method reserve_id is not covered by tests at /home/vagrant/kohaclone/C4/Reserves.pm line 859.
The method set is not covered by tests at /home/vagrant/kohaclone/C4/Reserves.pm line 871.
Can't call method "store" on an undefined value at /home/vagrant/kohaclone/C4/Reserves.pm line 871.

This is caused by
  commit ba1f2f93ef58c8dd935add3e215facdd4a589d12
    Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace

We are calling ->reserve_id on a Koha::Holds set.

Test plan:
- Serials -> Find subscription -> "Edit routing list" in the sidebar
- Add 1+ recipients
- Save -> "Save and preview routing slip"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
C4/Reserves.pm
t/db_dependent/Holds.t