From 1dee35d412f9aada8ae58d72a7fa1f4ff88dde7c Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Thu, 4 May 2023 06:41:19 +0000 Subject: [PATCH] Bug 33671: Fix for 30472 - Remove null-guarantors These guarantors cannot be added. They are of no use. NOTE FOR QA/RM: I do not think that it is needed to add a new db rev for this change since it happens seldom. But if you think that it is, just copy it to atomicupdate/change bugno. Test plan: [1] Check your table definition and modify it: alter table borrower_relationships modify column `guarantor_id` int(11) NULL; [2] Add an empty guarantor: insert into borrower_relationships (guarantee_id,relationship) values (SOME_PATRON_ID,'father'); [3] Run the dbrev and verify that the inserted record has been removed. [4] Check table definition with 'show create table borrower_relationships'. You should see NOT NULL with guarantor_id. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi --- installer/data/mysql/db_revs/220600048.pl | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/installer/data/mysql/db_revs/220600048.pl b/installer/data/mysql/db_revs/220600048.pl index 9c35ccec5d..8fb5e9c322 100755 --- a/installer/data/mysql/db_revs/220600048.pl +++ b/installer/data/mysql/db_revs/220600048.pl @@ -6,6 +6,11 @@ return { up => sub { my ($args) = @_; my ($dbh, $out) = @$args{qw(dbh out)}; + + # Delete 'empty' guarantors. No longer possible to add them via interface. Have no use. + $dbh->do(q{ +DELETE FROM borrower_relationships WHERE guarantor_id IS NULL + }); $dbh->do(q{ ALTER TABLE borrower_relationships CHANGE COLUMN guarantor_id guarantor_id int(11) NOT NULL }); -- 2.39.5