From a3977627dbde0172e65640e5d1d801bfbbbb474e Mon Sep 17 00:00:00 2001
From: Nick Clemens <nick@bywatersolutions.com>
Date: Fri, 28 May 2021 12:52:03 +0000
Subject: [PATCH] Bug 28408: Add 'Last updated' column to suggestions table

We have specific meanings for the different dates in suggestions
Managed - means the status was changed or the suggestion edited, but doesn't change if item type updated
Modification - implies an edit of the subscript, not updated if status changed alone
Updated - this is the date field in the DB, which is actually a timestamp

The cronjob purge_suggestions.pl uses teh 'date' field

For a user, a suggestion can look old in the interface, but be considered recent by the script

To clear the confusion we should show the timestamp as well

To test:
1 - Add a suggestion
2 - In the DB, pretend you set it in the past:
    UPDATE suggestions SET manageddate='2021-01-01', suggesteddate='2021-01-01', date='2021-01-01 12:12:12';
3 - Click 'Go' In Organize by: Status
4 - Note the suggestion looks old now
5 - Check the box, and click 'Update item types with:' -> Submit
6 - Prganize by status again
7 - No change?
8 - Check the DB:
    SELECT date FROM suggestions;
9 - The field is updated
10 - Apply patch
11 - Organize by status again
12 - See the 'Last updated' ate set to today

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit dacfa0bd20124a90dd802db11135728b29c6b1b4)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt    | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
index 610c82c488..e1b727c6f6 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
@@ -698,6 +698,7 @@
                                         <th>Managed on</th>
                                         <th>Last modification by</th>
                                         <th>Last modification on</th>
+                                        <th>Last updated</th>
                                         <th>Library</th>
                                         <th>Fund</th>
                                         <th>Status</th>
@@ -765,6 +766,9 @@
                                             <td data-order="[% suggestions_loo.lastmodificationdate | html %]">
                                                 [% IF ( suggestions_loo.lastmodificationdate ) %][% suggestions_loo.lastmodificationdate | $KohaDates %][% END %]
                                             </td>
+                                            <td>
+                                                [% suggestions_loo.date | $KohaDates %]
+                                            </td>
                                             <td>
                                                 [% Branches.GetName( suggestions_loo.branchcode ) | html %]
                                             </td>
-- 
2.39.5