From a531a75b628b04ed5638ddaf5add19e84e6779b5 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Joonas=20Kylm=C3=A4l=C3=A4?= Date: Wed, 15 Jul 2020 11:08:32 +0000 Subject: [PATCH] Bug 25992: Make SIP2 logger subroutines exportable to prevent crash If the subroutines are not exportable we get the following crash: > Undefined subroutine &C4::SIP::SIPServer::set_logger To test: In kohadevbox run for example: $ ps -aux # check that no existing sip server is running, kill the process if exists $ perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml $ koha/misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --item 3999900000001 -m item_information After applying this patch the Undefined subroutine error should be gone. Note: when using the sip_cli_emulator.pl the credentials can be anything. Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize (cherry picked from commit 082da615e649146197fbc9e0a20da672a82d4816) Signed-off-by: Lucas Gass --- C4/SIP/Logger.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/C4/SIP/Logger.pm b/C4/SIP/Logger.pm index 41169219d1..c73886cdc7 100644 --- a/C4/SIP/Logger.pm +++ b/C4/SIP/Logger.pm @@ -3,6 +3,9 @@ package C4::SIP::Logger; use Modern::Perl; +use base 'Exporter'; +our @EXPORT_OK = qw ( get_logger set_logger ); + our $activeSIPServer; our $activeLogger; -- 2.39.5