From fff0065785b0cd7e664eac3285a5f051cb94871a Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 4 Dec 2017 15:39:48 -0300 Subject: [PATCH] Bug 19638: Remove false positive obsolete reports (auth_header.marcxml) MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Bug 17898 tries to help users identify reports affected by the move of marcxml to the biblio_metadata table, however, the auth_header table still uses the column name 'marcxml' and so reports as needing updated though it doesn't. C4::Reports::Guided::convert_sql only converts if the sql query contain biblioitems and marcxml. We should use the same regexp in the controler script. Test plan: Use a sql report that use auth_header.marcxml (see https://wiki.koha-community.org/wiki/SQL_Reports_Library) After the this the report should not be longer marked as obsolete on the report list view Replicated bug with the following SQL: select marcxml from auth_header; Patch applied correctly and functioned as expected. Signed-off-by: Dilan Johnpullé Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens --- reports/guided_reports.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl index bfd0a7646b..106ddb528b 100755 --- a/reports/guided_reports.pl +++ b/reports/guided_reports.pl @@ -138,7 +138,7 @@ elsif ( $phase eq 'Build new' ) { my $has_obsolete_reports; for my $report ( @$reports ) { $report->{results} = C4::Reports::Guided::get_results( $report->{id} ); - if ( $report->{savedsql} =~ m|marcxml| ) { + if ( $report->{savedsql} =~ m|biblioitems| and $report->{savedsql} =~ m|marcxml| ) { $report->{seems_obsolete} = 1; $has_obsolete_reports++; } -- 2.39.5