]> git.koha-community.org Git - koha.git/commit
Bug 26434: Fix plugin dirs addition to @INC
authorFridolin Somers <fridolin.somers@biblibre.com>
Fri, 11 Sep 2020 14:03:28 +0000 (16:03 +0200)
committerVictor Grousset/tuxayo <victor@tuxayo.net>
Tue, 27 Oct 2020 14:20:06 +0000 (15:20 +0100)
commita1335333a6fb3b5b979a6f2b4141c8a852446eb7
treef47f86d9ed78a9556165f736c7bd2c4706bca5d0
parenta820ff385de4bc5ebeb0ac25209294ffd0f86969
Bug 26434: Fix plugin dirs addition to @INC

Plugin dirs defined in koha-conf.xml are added to @INC in order to compile perl code.
Looks like with plack those dirs are added several times.
This may lead to an error "INCLUDE_PATH exceeds 64 directories".

This bug was identified with Carrousel plugin : https://inlibro.com/instructions-carrousel/

Test plan :
1) Enable plack and plugins
2) Look at page about.pl : @INC contains one plugin dir 'var/lib/plugins'
3) Install plugin KitchenSink : https://github.com/bywatersolutions/koha-plugin-kitchen-sink
4) Dont apply patch
5) Use configure on KitchenSink
6) Look at page about.pl : @INC contains server plugin dir 'var/lib/plugins'
7) Apply patch and restart plack
8) Use configure on KitchenSink
9) Look at page about.pl : @INC contains one plugin dir 'var/lib/plugins'

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit dcdc72aee7d835c08ca3565a83a3dae7389a4f87)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit aaef04500654a997f722c17adff017a0a4687e8d)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
(cherry picked from commit 97a15fe1869dbdefcdb10f812a5adcb36becc7a7)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Koha/Plugins.pm
Koha/Plugins/Handler.pm