]> git.koha-community.org Git - koha.git/commit
Bug 23177: [18.11.x] (QA follow-up) Move three subs from the middle to the top in...
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fri, 21 Jun 2019 09:00:27 +0000 (09:00 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Tue, 13 Aug 2019 20:27:04 +0000 (20:27 +0000)
commitd460fe8304e6628732d4362b334b8a497f7a6239
treec0a208b4b5c49c5bf79d8b4579854ca4de34d024
parent89685c15a58c7697f93c8c99f6617168b29a8ee5
Bug 23177: [18.11.x] (QA follow-up) Move three subs from the middle to the top in Circulation.t

Removed trailing comma for last sub too.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Bug 23177: (QA follow-up) Move rollback to the end

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Bug 23177: (QA follow-up) Remove subtest txn_begin and rollback

This resolves:
DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1)
Removing unneeded subtest txn's. We should probably add them everywhere or
just at global level.

Test plan:
With all three patches applied, run Circulation.t a few times.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Bug 23177: (RM follow-up) Further test clarifications

This patch makes a few minor improvements to Circulation.t
1) Adds a name to some of the scoped blocks by converting them to
   subtests.
2) Adds output messages to some tests where they were missing.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Bug 23177: Rebase fixes

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
t/db_dependent/Circulation.t