From 556aa6f65eec6cde5697e4af58da8b35dcddc8b9 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Tue, 22 Oct 2019 11:10:59 +0200
Subject: [PATCH] Bug 23854: Fix failure on dates when editing a suggestion

- Watch plack-error-log
- Change an accepted suggestion to 'No Status'
- Verify error in the logs (use strict mode, depending on DBMS version)
- Status changed was not saved
- Apply patch
- Verify the error is gone, change is saved now.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 73198bc4bdafa6817c916c777a51a73d937ba2aa)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 suggestion/suggestion.pl | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl
index e1fca2611e..ef153ba88b 100755
--- a/suggestion/suggestion.pl
+++ b/suggestion/suggestion.pl
@@ -123,8 +123,11 @@ my $branchfilter = $input->param('branchcode') || C4::Context->userenv->{'branch
 ##  Operations
 ##
 if ( $op =~ /save/i ) {
-    $suggestion_only->{suggesteddate} = dt_from_string( $suggestion_only->{suggesteddate} )
-        if $suggestion_only->{suggesteddate};
+
+    for my $date_key ( qw( suggesteddate manageddate accepteddate rejecteddate ) ) {
+        $suggestion_only->{$date_key} = dt_from_string( $suggestion_only->{$date_key} )
+            if $suggestion_only->{$date_key};
+    }
 
     if ( $suggestion_only->{"STATUS"} ) {
         if ( my $tmpstatus = lc( $suggestion_only->{"STATUS"} ) =~ /ACCEPTED|REJECTED/i ) {
-- 
2.39.5