]> git.koha-community.org Git - koha.git/commit
Bug 27079: Floating point comparison correction
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Wed, 25 Nov 2020 12:58:56 +0000 (12:58 +0000)
committerAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Mon, 14 Dec 2020 15:35:14 +0000 (15:35 +0000)
commit198c3be9f0036b5b828d14941b3eae1898526b6a
treea4bbfc29924a0cf7045f8e8bb985f9f2d5765bc9
parentc8385e537c90054a54c37c5e9ad90f9ce845a002
Bug 27079: Floating point comparison correction

We cannot compare calculated values directly as those calculations may
have introduced floating point differences.  We have the
Koha::Number::Price->round function to consistently round the floating
point number to a decimal with 2 points precission for comparison.

Test plan
1/ Set a circ rule to have a .15 per day fine and enable finesMode
syspref.
2/ Issue an item of this type to a borrower (making it 12 days overdue
   by setting the due date to 12 days in the past)
3/ Run the fines job:
4/ Pay the fine for the patron
5/ Check in the item
6/ Note that the patron does not have an 'Overpayment refund' of $0.00

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Bug 27079: (QA follow-up) Round both sides for clarity

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit f99a22f276e429863d4168f7f92c60e66deeb82d)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
C4/Overdues.pm