From 1810fac11e5329804a6340dc60ebeb50527b7160 Mon Sep 17 00:00:00 2001
From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Mon, 18 Sep 2023 12:02:34 -0400
Subject: [PATCH] Bug 34820: Clarify inventory tool message for items with
 non-matching notforloan value

In the inventory tool, if one or more not for loan values are selected, and an item is scanned that has no NFL status or an unselected NFL status, the error message reads "Unknown not-for-loan status". This can be interpreted as the item having an NFL status value that is not defined in the system, but that is not accurate. This should be reworded to remove ambiguity.

Test plan:
1) Create two items, one of which has the NFL status of "Ordered", the
   other having no NFL status
2) Enter those two barcodes in the inventory tool barcodes list
3) Check only "Ordered" in items.notforloan
4) Note the problem messages
5) Apply this patch
6) Re-run the inventory tool
7) Note the new clarified messages!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt
index a430a3fc24..f7c4084a6b 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt
@@ -149,6 +149,7 @@
 
     <fieldset class="rows" id="optionalfilters">
             <legend>Optional filters for inventory list or comparing barcodes</legend>
+            <span class="hint">Scanned items are expected to match one of the selected <em>not for loan</em> critera if any are checked.</span>
             <br/>
             <div id="statuses" style="display: block;">
                   [% FOREACH status IN statuses %]
@@ -311,7 +312,11 @@
                 [% IF problem.key == 'wrongplace' %]
                     <span>Found in wrong place</span><br/>
                 [% ELSIF problem.key == 'changestatus' %]
-                    <span>Unknown not-for-loan status</span><br/>
+                    [% IF result.notforloan %]
+                        <span>Item has unselected <em>Not for loan</em> status <em>[% result.notforloan %]</em></span><br/>
+                    [% ELSE %]
+                        <span>Items has no <em>not for loan</em> status</span><br/>
+                    [% END %]
                 [% ELSIF problem.key == 'not_scanned' %]
                     <span>Missing (not scanned)</span><br/>
                 [% ELSIF problem.key == 'checkedout' %]
-- 
2.39.5