From 9eb4a39c05d7af3eef7b5f02a93d96b6dbd4689a Mon Sep 17 00:00:00 2001
From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Date: Thu, 7 Mar 2024 13:18:19 +0000
Subject: [PATCH] Bug 36120: Add pickup locations to place bookings modal

This patch adds a call to /biblios/biblionumber/pickup_locations to
fetch valid pickup locations for the biblio.

Upon selecting a pickup location we adapt the item select to only allow
for selecting items returned as valid for pickup at the selected
location.

Sponsored-by: Cuyahoga County Public Library
Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com>
Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 .../prog/en/includes/modals/place_booking.inc |  6 ++
 .../prog/js/modals/place_booking.js           | 87 ++++++++++++++++++-
 2 files changed, 91 insertions(+), 2 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/modals/place_booking.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/modals/place_booking.inc
index adaea50c76..1840e2b791 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/modals/place_booking.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/modals/place_booking.inc
@@ -25,6 +25,12 @@
                                 </select>
                                 <div class="hint">Enter patron card number or partial name</div>
                             </li>
+                            <li>
+                                <label class="required" for="booking_pickup">Pickup at:</label>
+                                <select name="booking_pickup" id="pickup_library_id" required="required" disabled="true"></select>
+                                <span class="required">Required</span>
+                            </li>
+                            <li>
                             <label for="booking_item_id">Item: </label>
                                 <select name="booking_item_id" id="booking_item_id" disabled="true">
                                     <option value="0">Any item</option>
diff --git a/koha-tmpl/intranet-tmpl/prog/js/modals/place_booking.js b/koha-tmpl/intranet-tmpl/prog/js/modals/place_booking.js
index 20f493873b..4b81e5f82f 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/modals/place_booking.js
+++ b/koha-tmpl/intranet-tmpl/prog/js/modals/place_booking.js
@@ -112,6 +112,66 @@ $("#placeBookingModal").on("show.bs.modal", function (e) {
 
     $("#booking_patron_id").on("select2:select", function (e) {
         booking_patron = e.params.data;
+        $("#pickup_library_id").prop("disabled", false);
+    });
+
+    // Pickup location select2
+    let pickup_url = "/api/v1/biblios/" + biblionumber + "/pickup_locations";
+    $("#pickup_library_id").kohaSelect({
+        dropdownParent: $(".modal-content", "#placeBookingModal"),
+        width: "50%",
+        dropdownAutoWidth: true,
+        allowClear: false,
+        ajax: {
+            url: pickup_url,
+            delay: 300, // wait 300 milliseconds before triggering the request
+            cache: true,
+            dataType: "json",
+            data: function (params) {
+                var search_term = params.term === undefined ? "" : params.term;
+                var query = {
+                    q: JSON.stringify({
+                        name: { "-like": "%" + search_term + "%" },
+                    }),
+                    _order_by: "name",
+                    _page: params.page,
+                };
+                query["patron_id"] = booking_patron.patron_id;
+                return query;
+            },
+            processResults: function (data) {
+                var results = [];
+                data.results.forEach(function (pickup_location) {
+                    results.push({
+                        id: pickup_location.library_id.escapeHtml(),
+                        text: pickup_location.name.escapeHtml(),
+                        needs_override: pickup_location.needs_override,
+                        pickup_items: pickup_location.pickup_items,
+                    });
+                });
+                return {
+                    results: results,
+                    pagination: { more: data.pagination.more },
+                };
+            },
+        },
+        templateResult: function (state) {
+            var $text;
+            if (state.needs_override === true) {
+                $text = $(
+                    "<span>" +
+                        state.text +
+                        '</span> <span style="float:right;" title="' +
+                        __(
+                            "This pickup location is not allowed according to circulation rules"
+                        ) +
+                        '"><i class="fa fa-exclamation-circle" aria-hidden="true"></i></span>'
+                );
+            } else {
+                $text = $("<span>" + state.text + "</span>");
+            }
+            return $text;
+        },
     });
 
     // Adopt periodPicker
@@ -389,6 +449,23 @@ $("#placeBookingModal").on("show.bs.modal", function (e) {
                     periodPicker.redraw();
                 });
 
+                // Setup listener for pickup location select2
+                $("#pickup_library_id").on("select2:select", function (e) {
+                    let valid_items = e.params.data.pickup_items;
+
+                    // Disable items not available at the pickup location
+                    $("#booking_item_id > option").each(function () {
+                        let option = $(this);
+                        let item_id = option.val();
+                        if (valid_items.includes(parseInt(item_id))) {
+                            option.prop("disabled", false);
+                        } else {
+                            option.prop("disabled", true);
+                        }
+                    });
+                    $("#booking_item_id").trigger("change.select2");
+                });
+
                 // Set onChange for flatpickr
                 let changeExists = periodPicker.config.onChange.filter(
                     f => f.name === "periodChange"
@@ -567,6 +644,8 @@ $("#placeBookingForm").on("submit", function (e) {
 
     let start_date = $("#booking_start_date").val();
     let end_date = $("#booking_end_date").val();
+    let pickup_library_id = $("#pickup_library_id").val();
+    let biblio_id = $("#booking_biblio_id").val();
     let item_id = $("#booking_item_id").val();
 
     if (!booking_id) {
@@ -575,7 +654,8 @@ $("#placeBookingForm").on("submit", function (e) {
             JSON.stringify({
                 start_date: start_date,
                 end_date: end_date,
-                biblio_id: $("#booking_biblio_id").val(),
+                pickup_library_id: pickup_library_id,
+                biblio_id: biblio_id,
                 item_id: item_id != 0 ? item_id : null,
                 patron_id: $("#booking_patron_id").find(":selected").val(),
             })
@@ -635,7 +715,8 @@ $("#placeBookingForm").on("submit", function (e) {
                 booking_id: booking_id,
                 start_date: start_date,
                 end_date: end_date,
-                biblio_id: $("#booking_biblio_id").val(),
+                pickup_library_id: pickup_library_id,
+                biblio_id: biblio_id,
                 item_id: item_id != 0 ? item_id : null,
                 patron_id: $("#booking_patron_id").find(":selected").val(),
             }),
@@ -693,6 +774,8 @@ $("#placeBookingModal").on("hidden.bs.modal", function (e) {
     $("#booking_patron_id").val(null).trigger("change");
     $("#booking_patron_id").empty();
     $("#booking_item_id").val(0).trigger("change");
+    $("#pickup_library_id").val(null).trigger("change");
+    $("#pickup_library_id").empty();
     $("#period").get(0)._flatpickr.clear();
     $("#booking_start_date").val("");
     $("#booking_end_date").val("");
-- 
2.39.5