From fd2423140705292b5f4d3b28afaf7abea7b7103a Mon Sep 17 00:00:00 2001
From: Katrin Fischer <katrin.fischer.83@web.de>
Date: Fri, 9 Jun 2023 09:46:47 +0000
Subject: [PATCH] Bug 33968: Add missing colons to guarantor related labels

Fixes some inconsistencies with the labels on the
patron detail page and patron edit form.

To test:
* Activate AllowStaffToSetCheckoutsVisibilityForGuarantor
  and AllowStaffToSetFinesVisibilityForGuarantor system
  preferences
* Link a patron to a guarantor
* Verify on the details tab the options for showing fines
  and checkouts show and are missing colons on the label
* Edit the patorn and verify the same is true for the form
* Apply patch
* Verify missing colons have been added :)

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit d7e189b5bf187184c83645b5d26cc49b56d8f408)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---
 .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt   | 4 ++--
 koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
index 35a0778aed..05f1cf66ce 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
@@ -581,7 +581,7 @@ legend:hover {
 
                                                 [% IF Koha.Preference('AllowStaffToSetCheckoutsVisibilityForGuarantor') %]
                                                     <li>
-                                                        <label for="privacy_guarantor_checkouts">Show checkouts to guarantors</label>
+                                                        <label for="privacy_guarantor_checkouts">Show checkouts to guarantors:</label>
                                                         <select name="privacy_guarantor_checkouts" id="privacy_guarantor_checkouts">
                                                             [% IF borrower_data.privacy_guarantor_checkouts %]
                                                                 <option value="0">No</option>
@@ -596,7 +596,7 @@ legend:hover {
                                                 [% END %]
                                                 [% IF Koha.Preference('AllowStaffToSetFinesVisibilityForGuarantor') %]
                                                     <li>
-                                                        <label for="privacy_guarantor_fines">Show charges to guarantors</label>
+                                                        <label for="privacy_guarantor_fines">Show charges to guarantors:</label>
                                                         <select name="privacy_guarantor_fines" id="privacy_guarantor_fines">
                                                             [% IF borrower_data.privacy_guarantor_fines %]
                                                                 <option value="0">No</option>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
index 991cf3c3c3..bad172ba54 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
@@ -182,7 +182,7 @@
                                             [% END %]
                                         [% END %]
                                          <li id="patron-privacyguarantor">
-                                            <span class="label">Show checkouts to guarantor</span>
+                                            <span class="label">Show checkouts to guarantor:</span>
                                             [% IF patron.privacy_guarantor_checkouts %]
                                                 Yes
                                             [% ELSE %]
@@ -191,7 +191,7 @@
                                         </li>
 
                                         <li id="patron-privacy_guarantor_fines">
-                                            <span class="label">Show charges to guarantor</span>
+                                            <span class="label">Show charges to guarantor:</span>
                                             [% IF patron.privacy_guarantor_fines %]
                                                 Yes
                                             [% ELSE %]
-- 
2.39.5