]> git.koha-community.org Git - koha.git/commit
Bug 21819: (QA follow-up) Replace onchange() in touched code
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tue, 20 Nov 2018 15:32:46 +0000 (16:32 +0100)
committerNick Clemens <nick@bywatersolutions.com>
Wed, 21 Nov 2018 11:30:49 +0000 (11:30 +0000)
commitaeaf74b7cc6608d7b81aaba10defdca6decdaa1d
treecb8d0f6a5329d8bc229875930231c0368904520f
parenta9fc00db03a8210b3edb69a922209a4e8f6df9a1
Bug 21819: (QA follow-up) Replace onchange() in touched code

AFAIK we should not call document...onchange() and assume that it works.
Apparently, it does at least in some browsers. But we are not sure.
We could easily replace them here by the documented jQuery counterpart.

Note: If you try git grep -l -E "onchange\(" you will find some
occurrences in two libraries and only in one js file (this one).
We should replace all occurrences here; will open a new report for that.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Verified that the change event was triggered: span should expand/collapse.

Signed-off-by: Andreas Roussos <arouss1980@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js