]> git.koha-community.org Git - koha.git/commit
Bug 16453: Make Elasticsearch tests be skipped if configuration entry missing
authorTomas Cohen Arazi <tomascohen@theke.io>
Thu, 5 May 2016 16:19:28 +0000 (13:19 -0300)
committerBrendan Gallagher <brendan@bywatersolutions.com>
Fri, 6 May 2016 03:47:05 +0000 (03:47 +0000)
commit0e6a18bb62eee31986a73a0811ab207aa746a381
tree5323291749537c98f3612fa173a6ea4a3af6cbf8
parent7b76b24fad305b0253eb1d779f074d265087ca73
Bug 16453: Make Elasticsearch tests be skipped if configuration entry missing

The current tests fail to run if the configuration entry is missing. This is
problematic on jenkins and should be fixed.

To test:
- On master, having koha-conf.xml without (or commented) an <elasticsearch> entry
- Run:
  $ prove t/db_dependent/Koha_ElasticSearch_Indexer.t \
          t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t -v
=> FAIL: Tests fail due to missing configuration entry
- Apply the patch
- Run:
  $ prove t/db_dependent/Koha_ElasticSearch_Indexer.t \
          t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t -v
=> SUCCESS: Tests pass, and the ES-configuration-dependent tests are skipped
- Have elasticsearch running and the koha-conf.xml entry
- Run:
  $ prove t/db_dependent/Koha_ElasticSearch_Indexer.t \
          t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t -v
=> SUCCESS: Same results as without the patch
- Sign off

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
t/db_dependent/Koha_ElasticSearch_Indexer.t
t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t