]> git.koha-community.org Git - koha.git/commit
Bug 19076 - Move issue logging in AddIssue into condtional clause
authorNick Clemens <nick@bywatersolutions.com>
Thu, 10 Aug 2017 15:20:58 +0000 (15:20 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Tue, 10 Oct 2017 09:04:50 +0000 (11:04 +0200)
commit112820ccdc847a0eca15432f070e0bbbaf5a3ed3
treeb4a5c8a7fa23c29dbe7896b3fff97aa098f7b54e
parentfb0472875711a8eb638e7b55b2dc412acbf51dea
Bug 19076 - Move issue logging in AddIssue into condtional clause

Currently AddIssue tests if renewal, but logs an issue even if so. This
patch moves the logging into the conditional so a log entry is only
added if we aren't renewing (as renewals are logged separately)

To test:
1 - prove t/db_dependent/Circulation.t - one test should fail
2 - Enable both issue and renewal logs
3 - Checkout an item to a patron
4 - View the logs - the issue is captured
5 - Checkout the item to the patron again and confirm renewal
6 - Both an issue and a renewal are logged
7 - Apply patch
8 Repeat 1-6, tests should pass and only renewal should be logged

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit b66b86402cd84026f7dabaa2e567a1956b9bbe86)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
C4/Circulation.pm