]> git.koha-community.org Git - koha.git/commit
Bug 27580: Handle NULL values correctly in Koha::Items->filter_by_visible_in_opac
authorTomas Cohen Arazi <tomascohen@theke.io>
Fri, 29 Jan 2021 19:43:06 +0000 (16:43 -0300)
committerVictor Grousset/tuxayo <victor@tuxayo.net>
Wed, 10 Feb 2021 00:55:47 +0000 (01:55 +0100)
commit1301051e3ead93944bcdda56e95e2ccc6dad9cf4
treefb69d33ee8f8d3f8c083cf1234d3029919b550a5
parent6617d5f699c02b193049f9bf4ee86bf03f7ddded
Bug 27580: Handle NULL values correctly in Koha::Items->filter_by_visible_in_opac

This patch fixes the internally used query so it doesn't consider NULL
values as IN the set.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Items.t
=> FAIL: Tests fail :-/
3. Apply this patch
4. Repeat 2
=> SUCCESS: tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit b60ff6452ef2212a02f16ddc5c46edeb3d83a5e3)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 606f47b2e91dcc51b1348356d672e95f8943ab8a)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
(cherry picked from commit 53811a1700f9e7083e24ab65f5b7291a2fa090be)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Koha/Items.pm