]> git.koha-community.org Git - koha.git/commit
Bug 16909: Koha::Patrons - Remove checkuniquemember
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 11 Jul 2016 22:07:34 +0000 (23:07 +0100)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 15 Jul 2016 18:14:57 +0000 (18:14 +0000)
commit1c61729e840655bfea7123d0c826a0cffa9bd1bc
tree5df1d49315754312e7ea92598a6439cc3b992049
parentdc78583de113bb9d24e29c2ca1c7d4033951fd59
Bug 16909: Koha::Patrons - Remove checkuniquemember

C4::Members::checkuniquemember was not really nicely written, was only
used once and was not covered by tests.
I think it does not make sense to keep such complexity and have this
code in the subroutine/method.
Looking at this patch it seems that what this subroutine did can be done
easily in the pl script in few lines.

Test plan:
1/ Create 2 organisations with the same "surname": you should get a
warning.
2/ Create 2 patrons (non-organisation) with the same
surname/firstname/date of birth, you should get a warning

Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/Members.pm
members/memberentry.pl