]> git.koha-community.org Git - koha.git/commit
Bug 19437: Rearranging tests for CancelExpiredReserves
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fri, 6 Oct 2017 08:41:29 +0000 (10:41 +0200)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 13 Oct 2017 07:47:11 +0000 (09:47 +0200)
commit2516945bf5f74359b62df8f6d07053a9761bda54
treea2e4ea16e48deadc372da130019f8eb07cf532ba
parentb7c7c331424536c055c83cfb47eba3903a9b39c8
Bug 19437: Rearranging tests for CancelExpiredReserves

This patch originates from a QA Follow-up on bug 19260.

The first 19260 patch adds CancelExpiredReserves tests to Reserves.t.
But note that we already have some tests in Holds/CancelReserves.t.

This patch does:
Renames Holds/CancelReserves.t to Reserves/CancelExpiredReserves.t.
Rearranges modules there.
Moves its existing tests into a first subtest.
Moves the new subtest from Reserves.t to CancelExpiredReserves.t.
Replaces $dbh->do('DELETE FROM reserves').
Adds some TestBuilder statements for missing data (by the move): adding
biblio, item, borrower (removing slow AddMember call).

Test plan:
Run Reserves.t and Reserves/CancelExpiredReserves.t.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 511b3253576262878c953e7a3fe4a2941686ab1e)
t/db_dependent/Holds/CancelReserves.t [deleted file]
t/db_dependent/Reserves.t
t/db_dependent/Reserves/CancelExpiredReserves.t [new file with mode: 0644]