]> git.koha-community.org Git - koha.git/commit
Bug 18802: Fix Circulation.t if finesMode ne 'production'
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 14 Jun 2017 14:32:30 +0000 (11:32 -0300)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 29 Sep 2017 08:53:24 +0000 (10:53 +0200)
commit300a76a573673b74ad0863c3b93c6ea3a66eb1ea
tree773b7ea8719db6e079da9002538afb168f263c72
parent1f19154532f438319aa789d8b7cdabb14f53275a
Bug 18802: Fix Circulation.t if finesMode ne 'production'

If finesMode is not set to production, only 1 fine will be created (the renewal
one will not). This is what assumes the tests.
If set to 'production', the tests will fail because the fines will not
be deleted (because of the DBIx::Class) warning.
Now we mock the value before charging.

prove t/db_dependent/Circulation.t
t/db_dependent/Circulation.t .. 16/95 DBIx::Class::Storage::DBI::select_single(): Query returned more than one row.  SQL that returns multiple rows is DEPRECATED for ->find and ->single at t/db_dependent/Circulation.t line 491
t/db_dependent/Circulation.t .. 56/95
    #   Failed test 'Can auto renew, OPACFineNoRenewals=10, patron has 10'
    #   at t/db_dependent/Circulation.t line 670.
    #          got: 'auto_too_much_oweing'
    #     expected: 'auto_renew'
    # Looks like you failed 1 test of 6.

Test plan:
  prove t/db_dependent/Circulation.t
should return green whatever the value of finesMode

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit ae5f5c479929cbfad3193c6ce9471a406a2a41f3)
t/db_dependent/Circulation.t