]> git.koha-community.org Git - koha.git/commit
Bug 18355: (QA follow-up) Rearrange comments, improve code
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fri, 29 Nov 2019 10:57:18 +0000 (10:57 +0000)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 13 Jan 2020 13:58:05 +0000 (13:58 +0000)
commit312e773d65624f37bc9597df2db471c3f7877127
treef5b0522c62b28c6eff7f5b5604ebdd56cb14064a
parent44e4110d6ee712e0a78646590d6df12aa7d0449f
Bug 18355: (QA follow-up) Rearrange comments, improve code

Comments were hard to read (for me) but tastes differ..

Code should reflect that permanent_location is a code and that location
may be already an authval. See detail.pl:
$item->{'location'} = $shelflocations->{$shelfcode} if ( defined( $shelfcode ) && defined($shelflocations) && exists( $shelflocations->{$shelfcode} ) );

Obviously, this kind of logic divided over two places should be reduced.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt