]> git.koha-community.org Git - koha.git/commit
Bug 23612: (RM follow-up) Fix failing tests
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 4 Oct 2019 12:19:18 +0000 (13:19 +0100)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 7 Oct 2019 09:59:50 +0000 (10:59 +0100)
commit43519c0525a07b8f784fd9166eb0db3430e29042
tree0957cd85bfb4dc22881ec8ac00939c7f4ac7d6e0
parent1175b9fb8703376d051267446dc9c585442c2201
Bug 23612: (RM follow-up) Fix failing tests

Trailing comma's were causing hidden javascript errors during selenium
tests.

Error was identified by adding a $s->capture($driver) line to the
relevant selenium test and using the following JS snippet to dump errors
to the screen.

   (function () {
       var ul = null;
       function createErrorList() {
           ul = document.createElement('ul');
           ul.setAttribute('id', 'js_error_list');
           //ul.style.display = 'none';
           document.body.appendChild(ul);
       }
       window.onerror = function(msg){
           if (ul === null)
               createErrorList();
           var li = document.createElement("li");
           li.appendChild(document.createTextNode(msg));
           ul.appendChild(li);
       };
   })();

Which clearly showed the following error.

    ReferenceError: KohaTable is not defined

Removing the trailing comma's introduced in this bug resolved the issue.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc