]> git.koha-community.org Git - koha.git/commit
Bug 23220: Prevent form submission before redirect
authorNick Clemens <nick@bywatersolutions.com>
Wed, 26 Jun 2019 12:49:14 +0000 (12:49 +0000)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 28 Jun 2019 13:25:54 +0000 (14:25 +0100)
commit4dcf416dc9547fd28e6ed846d08d6bbecb144552
treea81925deb06a91e0a2bf95ef7e4f622c7f596d65
parent466f99e44230968aeb51598e50f65d212941c5b4
Bug 23220: Prevent form submission before redirect

To test:
 1 - Check in an item to generate a transfer (form another library, no floating)
 2 - Check it in again, click 'Cancel transfer'
 3 - It may or may not work
 4 - To highlight the issue edit return.tt to add the delay line as below:
$('.cancel-transfer').on("click",function(e){
delay(5000);
window.location.href='/cgi-bin/koha/circ/returns.pl?itemnumber=[% itemnumber | html %]&amp;canceltransfer=1'
});
 5 - Check in the item repeatedly, click 'Cancel transfer'
 6 - View the item in the staff or opac and verify it remains in transit
 7 - Undo changes above, apply patch
 8 - Test 'Cancel transfer', note it works
 9 - Add the delay back in, confirm it still works

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt