]> git.koha-community.org Git - koha.git/commit
Bug 26964: Newly created macros should be selected in the Advanced editor
authorPhil Ringnalda <phil@chetcolibrary.org>
Fri, 26 Feb 2021 21:39:37 +0000 (13:39 -0800)
committerAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Sun, 14 Mar 2021 20:00:31 +0000 (20:00 +0000)
commit547198124ce0df3c91c576109f4476777e00441a
tree0ad30500551bf356a1c45cb34812fd1b5f03cb6f
parentfbc96a7d31cf7d98ea3827c68f47980f961411d9
Bug 26964: Newly created macros should be selected in the Advanced editor

The problem is that the newly created macro isn't selected, because the
return values from the call to create it are accidentally thrown away. There
isn't actually any option to save, just a timeout that automatically saves,
but you can tell you are in this broken state because the Delete macro
button is disabled.

Test plan:

1. Prior to applying the patch, Administration - set the preference
   EnableAdvancedCatalogingEditor to Enable
2. Cataloging - Advanced editor - Macros... - New macro...
3. Give it a name, click OK, notice that the Delete macro button is disabled
4. Apply patch, shift+reload
5. Macros... - New macro...
6. Give it a name, click OK, notice that the Delete macro button is enabled
7. Type something in the editor, delete 999 will do nicely, wait half a
   second to see Saved appear at the far right, close the macro popup
8. Macros..., click the name of your macro, verify it really was saved

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit f17d3dd62cfcbe7de3b74573b48e09e42e6b0eab)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 4073805058c7a1932258cd6f61b6928bcf9a4bbc)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc