]> git.koha-community.org Git - koha.git/commit
Bug 19638: Remove false positive obsolete reports (auth_header.marcxml)
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 4 Dec 2017 18:39:48 +0000 (15:39 -0300)
committerFridolin Somers <fridolin.somers@biblibre.com>
Wed, 20 Dec 2017 11:11:54 +0000 (12:11 +0100)
commit6f443b31fac8e9518ea81210281a796bc5cbbaf5
tree91041a94e936fe399a3cdcaeeb46a0cfa62fe91a
parentba1af627c73b4d17ceaf397f0c52477faf12b98f
Bug 19638: Remove false positive obsolete reports (auth_header.marcxml)

Bug 17898 tries to help users identify reports affected by the move of marcxml to the biblio_metadata table, however, the auth_header table still uses the column name 'marcxml' and so reports as needing updated though it doesn't.

C4::Reports::Guided::convert_sql only converts if the sql query contain biblioitems and marcxml.
We should use the same regexp in the controler script.

Test plan:
Use a sql report that use auth_header.marcxml (see https://wiki.koha-community.org/wiki/SQL_Reports_Library)
After the this the report should not be longer marked as obsolete on the report list view

Replicated bug with the following SQL:
select marcxml from auth_header;

Patch applied correctly and functioned as expected.

Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit fff0065785b0cd7e664eac3285a5f051cb94871a)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
reports/guided_reports.pl