Bug 37525: [SCO] Regression in 32256: "Return this item" doesn't show up despite SCOAllowCheckin being allowed
There's a regression in bug 32256 and commit
bb059abe respectively:
https://gitlab.com/koha-community/Koha/-/commit/
bb059abe90#a22dc682a84c41672294c66e441329a451b5cd5a_137_137
The refactoring of "renew" -> "c.renew" missed this line (at least), so the condition is never met.
This fixes the issue and restores the original functionality.
Test plan:
1. log in with a patron at http://localhost:8080/cgi-bin/koha/sco/sco-main.pl
2. check out an item
3. scan it again
4. see that the "return this item" choice isn't proposed. This is the
bug
5. apply patches
6. rescan the item in the self-check out
7. returning is proposed
8. check it in and confirms that it's not checked out anymore
Signed-off-by: Oliver Behnke <oliver.behnke@aei.mpg.de>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>