]> git.koha-community.org Git - koha.git/commit
Bug 5471 - Quotes in tags fail
authorOwen Leonard <oleonard@myacpl.org>
Fri, 9 Jun 2017 12:29:58 +0000 (12:29 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 29 Sep 2017 09:17:05 +0000 (11:17 +0200)
commit9dcaeba3e05e9f5bd9b2c3375edf92b749aa7dfd
tree89e9ab411dbb551ebaab00bc758bf7326eef9dfc
parent7f0612052770654aaa7d5344d18522dbfc8b9aab
Bug 5471 - Quotes in tags fail

This patch makes changes to the tag moderation template and JavaScript
to fix handling of tags with double or single quotes. This patch also
moves the tags moderation JavaScript out of the template and into a
separate JS file.

To test you should have multiple tags awaiting moderation, including
tags which contain double and single quotes.

- Go to Tools -> Tags.
- In the list of tags pending approval, test approving and rejecting
  tags, including those containing single or double quotes.
  - The state of the "Approve" or "Reject" buttons should correctly
    change according to the action you chose.
  - The label in the status column should update correctly.
- In the "Check lists" form, submitting approved, rejected, and
  unclassified terms should result in the correct message.

Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Works correctly based on test plan. Tested using single- and
double-quoted tags. Passes QA Tools.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit ee6f8e186bc93df9d7943ea38f05615b2e8a813f)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt
koha-tmpl/intranet-tmpl/prog/js/pages/tags-review.js [new file with mode: 0644]
tags/review.pl