]> git.koha-community.org Git - koha.git/commit
Bug 28302: Forbid CGI::Compile 0.24
authorJulian Maurice <julian.maurice@biblibre.com>
Fri, 7 May 2021 15:57:58 +0000 (17:57 +0200)
committerAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Tue, 25 May 2021 13:35:24 +0000 (13:35 +0000)
commita01ef6e5e583eaa9706c1275d7df8f56766c0592
tree7e927273bde7180106fc7a30753e829d38acbdf1
parent644fd8dad4f441b75103188ccbea14d0144289e0
Bug 28302: Forbid CGI::Compile 0.24

CGI::Compile 0.24 has a bug:
https://github.com/miyagawa/CGI-Compile/issues/25

It can cause weird bugs, like breaking the authority detail display
after trying to modify an authority.

Steps to reproduce:
1. Install CGI::Compile 0.24
2. Restart starman with only 1 worker
3. Go to the detail page of an authority (authorities/detail.pl)
4. Go to the edit page (Edit ยป Edit record)
5. Check starman logs, you should see "Subroutine build_tabs redefined
at [...]"
6. Click on cancel to go back to the detail page, which should now show
a "blank" authority. Now the only way to get the authority back is to
restart starman.

Test plan:
1. Reproduce the bug
2. Install CGI::Compile 0.25 and restart starman
3. Make sure the bug is gone :)

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 4a3049a8be8dc2d22eac796521a4185f1248282a)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 32368e932fc0ec8178176da237bfaa390656f50f)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
cpanfile