]> git.koha-community.org Git - koha.git/commit
Bug 24616: Allow copying notice to a branch even if it exists in that branch
authorEmmi Takkinen <emmi.takkinen@koha-suomi.fi>
Thu, 28 Jul 2022 12:22:20 +0000 (15:22 +0300)
committerMatt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Tue, 7 Feb 2023 15:23:12 +0000 (15:23 +0000)
commitd58fad747981f43e5ae4da072936f410b437db5d
treef29411c9933e2037db621055f35797cede08dba2
parentfa138594490837e3d9a77443150361228b02f481
Bug 24616: Allow copying notice to a branch even if it exists in that branch

If you try to copy notice or slip to a branch which already
has that notice or slip Koha won't let you save it. Instead
pop-up saying branch already has that notice is displayed.

This patch allows users to copy and override already existing
notice or slip.

To test:
1. Find notice which exists e.g. in all branches and branch A.
2. Copy that notice, add notice screen is displayed.
3. Press save.
=> Pop-up informing that notice already exists in branch A
is displayed.
4. Apply this patch.
5. Repeat steps 2. and 3.
6. Pop-up to confirm overwrite of notice is displayed.
=> Confirm that if you press OK, notice is saved succesfully.
=> Otherwise, changes to notice should not be saved.

Also try to save the notice you tested with as a new (same code)
to branch A. Confirm that pop-up is displayed as it should be.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Nick <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 7362059bb60222ea5a03b23ae7c621933fa81adc)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
koha-tmpl/intranet-tmpl/prog/js/letter.js