]> git.koha-community.org Git - koha.git/commit
Bug 27593: Consistent behavior for club holds route
authorTomas Cohen Arazi <tomascohen@theke.io>
Tue, 2 Feb 2021 14:22:50 +0000 (11:22 -0300)
committerFridolin Somers <fridolin.somers@biblibre.com>
Thu, 25 Feb 2021 09:52:37 +0000 (10:52 +0100)
commite1f35cf3474952a851e62a2366fd520f0b413228
treeb6bc86fb84d3bb86ecb2e5cee8e55d1ff80ad634
parente950abb5352aa29d91de47a40f67067d237836fb
Bug 27593: Consistent behavior for club holds route

This patch:
- Fixes a malformed response when biblio_id is invalid
- Fixes the return status (400 => 404) when biblio_id is invalid
- Adapts the error strings to be consistent with the Cities.pm file

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/clubs_holds.t
=> FAIL: Tests fail
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 2387ac731c03ecfa6cd20e7e71037bbd3c3ac046)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Koha/REST/V1/Clubs/Holds.pm