]> git.koha-community.org Git - koha.git/commit
Bug 26581: [20.05.x] Only reindex records once per checkin
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 16 Oct 2020 14:04:31 +0000 (15:04 +0100)
committerLucas Gass <lucas@bywatersolutions.com>
Mon, 16 Nov 2020 18:01:30 +0000 (18:01 +0000)
commite5367af11159b33f43c0cef0968f204366dbad99
treefd3b9cb1c610d36f1356d46f0f19c7c243f6dfba
parent694f5ee9d8b21532c04598498e10f9f6c7e542c0
Bug 26581: [20.05.x] Only reindex records once per checkin

This patch simply passes skip_record_index calls to Koha:Item:store
for all the changes done in AddReturn.

Testing is really verifiying that items are still correctly indexed at the end

For both search engines
To test:
1 - Find or create a record with multipel items
2 - Populate both:
     UpdateItemLocationOnCheckin
     UpdateNotForLoanStatusOnCheckin
3 - Confirm that checking in an item correctly updates the item status in search results
4 - Test with items issued, and items not issued
5 - Test when generating a transfer (checkin at different branch)
6 - Test when item was marked lost
7 - Test when filling transfer

Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Signed-off-by: Christoper Brannon <cbrannon@cdalibrary.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Bug 26581: Unit tests

These tests cover the changes to ensure the AddReturn calls index_records once
per call and that other calls pass the skip_record_index parameter correctly

Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Signed-off-by: Christoper Brannon <cbrannon@cdalibrary.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
C4/Circulation.pm
C4/Items.pm
t/db_dependent/Koha/SearchEngine/Indexer.t