]> git.koha-community.org Git - koha.git/commit
Bug 28367: Fix plack condition in C4/Auth_with_shibboleth.pm
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 18 May 2021 08:43:05 +0000 (10:43 +0200)
committerVictor Grousset/tuxayo <victor@tuxayo.net>
Fri, 28 May 2021 06:07:46 +0000 (08:07 +0200)
commite914f9c12a05fa43c04a6b7cf0b2ab0bfba603b1
treee453b1429897748ad9b22c31260d10eecd1b5c83
parentbc3fd9edb7074f524308d41a14878a5ae908ccdf
Bug 28367: Fix plack condition in C4/Auth_with_shibboleth.pm

C4/Auth_with_shibboleth.pm has:
  if ( any { /(^psgi\.|^plack\.)/i } keys %ENV )
When others have:
  if ( any { /(^psgi\.|^plack\.)/i } keys %ENV )

This has been highlighted by https://gitlab.com/koha-community/koha-testing-docker/-/issues/249 that introduces a PLACK_WORKERS env vars, and t/Auth_with_shibboleth.t was failing with

 #   Failed test 'checkpw_shib tests'
 #   at t/Auth_with_shibboleth.t line 335.
 Invalid parameter passed, categorycode= does not exist# Looks like your test exited with 255 just after 5.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 21d8298c7708281a9ab87851ea55f75559e57cf4)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 794e3b3505464c2da846192b58d3e6a23e939d0c)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
(cherry picked from commit 10702f3402b49b3ed88ca43695b5223eb4a921aa)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
C4/Auth_with_shibboleth.pm