]> git.koha-community.org Git - koha.git/commit
Bug 26114: ILL should mark status=RET only if a return happened
authorTomas Cohen Arazi <tomascohen@theke.io>
Fri, 31 Jul 2020 14:14:20 +0000 (11:14 -0300)
committerLucas Gass <lucas@bywatersolutions.com>
Mon, 17 Aug 2020 15:35:11 +0000 (15:35 +0000)
commitf0791ad68b491dcbe183073160fc05112e3fd1df
treedc6b9c0910fda663d7f19fadf0091ba6f1543a5f
parentc2a765959a0ff251f613db753c136af14a96e1dd
Bug 26114: ILL should mark status=RET only if a return happened

The original code assumed every codepath should be trated as a
successful check-in. Such is not the case and the regression tests
verify that the code acknowledges this.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Illrequests.t
=> FAIL: Tests fail
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit f916269465df99818fb15c108820d3b666968d39)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
C4/Circulation.pm