]> git.koha-community.org Git - koha.git/commit
Bug 37833: Incorrect logic controlling display of OPAC language selection menus
authorOwen Leonard <oleonard@myacpl.org>
Wed, 4 Sep 2024 16:03:07 +0000 (16:03 +0000)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Fri, 13 Sep 2024 10:02:51 +0000 (12:02 +0200)
commitf7a592873e03dbbd8af3488dee258fbfeca7731c
treefffc92c066178eb9a875630d15dd00a1a9f48b0c
parent54aad5771a7c492c70e53e7b52d8989c5b427cf5
Bug 37833: Incorrect logic controlling display of OPAC language selection menus

This patch corrects the logic around how the OPAC language menus are
displayed. Because the footer and header lanugage menus have been
combined into one, the logic for whether the menu should appear has to
live outside the include. The patch also makes corrections to ensure
that the footer menu appears even if the footer language menu is hidden.

NOTE: This patch contains whitespace changes, so please view the diff
accordingly.

To test you should have at least one additional language installed.

- Apply the patch and make sure the OPACLanguages system preference has
  more than one language checked.
- Set opaclanguagesdisplay to "Allow."
- In the OPAC, test that the various settings of the
  OpacLangSelectorMode preference work correctly (only top, only footer,
  both top and footer).
- Test with OPACReportProblem on and off, and CookieConsent on and off.
- Test with OPACReportProblem or CookieConsent enabled and
  opaclanguagesdisplay disabled.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
koha-tmpl/opac-tmpl/bootstrap/en/includes/langmenu.inc
koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc