From 04d6f406ffc52cf60768fe38530aebf8c03add03 Mon Sep 17 00:00:00 2001 From: Pasi Kallinen Date: Thu, 25 Jan 2018 13:04:09 +0200 Subject: [PATCH] Bug 11827: Make "Cancel Rating" translatable in jQuery rating plugin - Make the "Cancel rating" text translatable (and change capitalization to conform to Koha coding guidelines) - Improve the two other messages to use formatted strings instead of concatenation. - Use the exact same text for the "your rating" text, so it only appears once in the po-file. Test plan: 1. See that the "Cancel rating" -text doesn't appear in po/xx-YY-opac-bootstrap.po 2. Note how there's two versions of the your rating -text ("your rating: %s, " and "your rating:") in the po-file 3. Apply patch 4. Update the xx-YY translation 5. Check the po-file. It should now contain the "Cancel rating" and a single "your rating: %s, " 6. Translate those texts, and update & install the language. 7. Go to the OPAC detail page of a biblio, and check the rating texts. 8. Hovering over the rating minus -sign should show the translated "Cancel rating" 9. Check that the text after the stars is correct with and without your rating Signed-off-by: Pasi Kallinen Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt index 97ea7a0b42..37e9800494 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ -1655,6 +1655,7 @@ $(function () { $(".auto-submit-star").rating({ + cancel: _('Cancel rating'), callback: function (value, link) { // if the new value equals the old value, dont execute callback... @@ -1677,12 +1678,12 @@ $("#rating_value").val(data.rating_value); if (data.rating_value) { - $("#rating_value_text").text(_("your rating: ") + data.rating_value + ", "); + $("#rating_value_text").text(_("your rating: %s, ").format(data.rating_value)); } else { $("#rating_value_text").text(''); } - $("#rating_text").text(_("average rating: ") + data.rating_avg + " (" + data.rating_total + ' ' + _("votes") + ")"); + $("#rating_text").text(_("average rating: %s (%s votes)").format(data.rating_avg, data.rating_total)); } }, "json"); -- 2.39.5