From 0b9bd169194476a8a33ef61e1ee82b2f0839c34a Mon Sep 17 00:00:00 2001 From: Mason James Date: Tue, 3 Sep 2019 16:02:32 +1200 Subject: [PATCH] Bug 23530: Fix cart showing only hidden items Items hidden with the OpacHiddenItems system preference were still displayed in the OPAC cart and the normal items were hidden instead. This patch corrects the display. To test: - prep a test bib with hidden and other items using the OpacHiddenItems system preference - add bib to cart - observe that hidden items are displayed - non-hidden items are hidden - apply patch, reload page - observe that hidden items are hidden, non-hidden items are displayed Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize (cherry picked from commit 60ce66b6b658bfbe0d9ca459afc673042c7a854f) Signed-off-by: Fridolin Somers (cherry picked from commit 6e013cf383f1f23b34e9878a86ea0b945833132f) Signed-off-by: Lucas Gass --- opac/opac-basket.pl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/opac/opac-basket.pl b/opac/opac-basket.pl index c2d57f2f5e..581cd2b80b 100755 --- a/opac/opac-basket.pl +++ b/opac/opac-basket.pl @@ -18,7 +18,6 @@ use Modern::Perl; use CGI qw ( -utf8 ); -use List::Util qw/none/; # well just one :) use C4::Koha; use C4::Biblio; @@ -100,12 +99,14 @@ foreach my $biblionumber ( @bibs ) { # copy the visible ones into the items array. my @items; foreach my $item (@all_items) { - if ( none { $item->{itemnumber} ne $_ } @hidden_items ) { + + # next if item is hidden + next if grep { $item->{itemnumber} eq $_ } @hidden_items ; + my $reserve_status = C4::Reserves::GetReserveStatus($item->{itemnumber}); if( $reserve_status eq "Waiting"){ $item->{'waiting'} = 1; } if( $reserve_status eq "Reserved"){ $item->{'onhold'} = 1; } push @items, $item; - } } my $subtitle = GetRecordValue('subtitle', $record, GetFrameworkCode($biblionumber)); -- 2.39.5