From 26bb5683bd270691404314b748e0f3cfe8ce080b Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Mon, 14 Jan 2013 09:02:38 -0800 Subject: [PATCH] Bug 27562: itiva notices break if record title contains quotes itiva has reported to us that quotes in the title of a record cause the call to not be made to the patron. The fix is to remove quotes from the title, as quotes are not spoken anyway ( That is, "Queens" and "Queen's" are pronounced the same ). Test Plan: 1) Set up itiva to send phone notes 2) Find a record with quotes in the title 3) Trigger an itiva notice ( checkout, checkin, place hold, etc ) using the itiva outbound cronjob 4) View the CSV, note the title has the quotes in it 5) Apply this patch 6) Repeat steps 2-3 7) View the CSV, note the title contains no quotes! Signed-off-by: Owen Leonard Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart (cherry picked from commit e7aac53e9a33763724b7f0a0e9ac69518f0a926b) Signed-off-by: Fridolin Somers (cherry picked from commit 0c1af441122dbdd3db590de38b55e5158d153f61) Signed-off-by: Andrew Fuerste-Henry --- misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl | 3 +++ 1 file changed, 3 insertions(+) diff --git a/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl b/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl index 1131da61e2..9fa4939488 100755 --- a/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl +++ b/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl @@ -160,6 +160,9 @@ foreach my $type (@types) { ); } + $issues->{title} =~ s/'//g; + $issues->{title} =~ s/"//g; + print $OUT "\"$format\",\"$language\",\"$type\",\"$issues->{level}\",\"$issues->{cardnumber}\",\"$issues->{patron_title}\",\"$issues->{firstname}\","; print $OUT "\"$issues->{surname}\",\"$issues->{phone}\",\"$issues->{email}\",\"$library_code\","; print $OUT "\"$issues->{site}\",\"$issues->{site_name}\",\"$issues->{barcode}\",\"$due_date\",\"$issues->{title}\",\"$message_id\"\n"; -- 2.39.5