From 37d6bafcf8b8a1570a0344b9817eb6f95f23ce42 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Tue, 27 Feb 2018 15:54:38 -0300
Subject: [PATCH] Bug 20303: Do not explode when receiving an order if
 authorisedby not set

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
---
 acqui/orderreceive.pl | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/acqui/orderreceive.pl b/acqui/orderreceive.pl
index e876942884..c88a533efe 100755
--- a/acqui/orderreceive.pl
+++ b/acqui/orderreceive.pl
@@ -185,6 +185,12 @@ my $suggestion = GetSuggestionInfoFromBiblionumber($order->{biblionumber});
 
 my $authorisedby = $order->{authorisedby};
 my $authorised_patron = Koha::Patrons->find( $authorisedby );
+if ( $authorised_patron ) { # This should not happen unless there was a migration issue (or very old install?)
+    $template->param(
+        memberfirstname  => $authorised_patron->firstname || "",
+        membersurname    => $authorised_patron->surname || "",
+    );
+}
 
 my $budget = GetBudget( $order->{budget_id} );
 
@@ -217,8 +223,6 @@ $template->param(
     ecost                 => $ecost,
     unitprice             => $unitprice,
     tax_rate              => $tax_rate,
-    memberfirstname       => $authorised_patron->firstname || "",
-    membersurname         => $authorised_patron->surname || "",
     invoiceid             => $invoice->{invoiceid},
     invoice               => $invoice->{invoicenumber},
     datereceived          => $datereceived,
-- 
2.39.5