From 49029a40b7cd10259e08c827eef0f933d6853dd1 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 13 Sep 2019 07:36:25 +0000 Subject: [PATCH] Bug 22037: (QA follow-up) Correct misleading comment Comment needs to be corrected, and now applies to the whole code paragraph following it. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit 766814ffa3c4592b9b7dcde83873ef12e796ae68) Signed-off-by: Fridolin Somers (cherry picked from commit 4c15068ec0f6b113ecb227d9afd2bbae7624661e) Signed-off-by: Lucas Gass --- C4/SIP/ILS/Patron.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/C4/SIP/ILS/Patron.pm b/C4/SIP/ILS/Patron.pm index 3f5bfe21d4..5b592abd71 100644 --- a/C4/SIP/ILS/Patron.pm +++ b/C4/SIP/ILS/Patron.pm @@ -66,7 +66,8 @@ sub new { my $dexpiry = $kp->{dateexpiry}; $dexpiry and $dexpiry =~ s/-//g; # YYYYMMDD - my $fines_amount = $flags->{CHARGES}->{amount}; # This "amount" is the negative balance or the one of the guarantees + # Get fines and add fines for guarantees (depends on preference NoIssuesChargeGuarantees) + my $fines_amount = $flags->{CHARGES}->{amount}; $fines_amount = ($fines_amount and $fines_amount > 0) ? $fines_amount : 0; my $guarantees_fines_amount = $flags->{CHARGES_GUARANTEES} ? $flags->{CHARGES_GUARANTEES}->{amount} : 0; $fines_amount += $guarantees_fines_amount; -- 2.39.5