From 63d4393fb691e4d4b695e5838e6c1dd9b989cc1a Mon Sep 17 00:00:00 2001
From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Date: Mon, 20 Jul 2020 09:40:00 +0100
Subject: [PATCH] Bug 26017: Correct permission check on tools page

The 'Cashup registers' link from the tools page retained an previous
verions of the permission name. This patch corrects it to use the final
name we sebtled on and thus now correctly displays the link when
appropriate.

Test plan
1/ Enable cash registers via the 'UseCashRegisters' system preference
2/ Ensure you are logged in as a user who has the cash management
   cashup permission.
3/ Verify that the 'Cashup registers' option appears on the tools page.

Signed-off-by: Michal Denar <black23@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit ff4917197deaa6250d30c5729b2758db2b1f755e)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
index ae4608c684..350fd1b28d 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
@@ -135,11 +135,9 @@
     <dd>Access files stored on the server, like log files or reports</dd>
     [% END %]
 
-    [% IF ( Koha.Preference('UseCashRegisters') && CAN_user_cash_management_manage_cash_registers ) %]
-        [% IF ( CAN_user_cash_management_manage_cash_registers ) %]
+    [% IF ( Koha.Preference('UseCashRegisters') && CAN_user_cash_management_cashup ) %]
         <dt><a href="/cgi-bin/koha/pos/registers.pl">Cashup registers</a></dt>
-        <dd>Perfrom cashup actions on cash registers</dd>
-        [% END %]
+        <dd>Perform cashup actions on cash registers</dd>
     [% END %]
 
     [% IF ( Koha.Preference('OPACReportProblem') && CAN_user_problem_reports ) %]
-- 
2.39.5