From afc7a991956ba8ebe8b9be79a56bcdef01bf2003 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Fri, 11 Jan 2019 14:52:28 +0000
Subject: [PATCH] Bug 22102: Markup fixes for OPAC article request page

This patch makes a few improvements to the OPAC article request page:

- Improve the breadcrumbs menu by adding a link to the title
- Add a header with the record's title
- Wrap the "no article requests" message in the correct dialog div
- Remove obsolete CDATA marker

To test, apply the patch and log in to the OPAC

 - Peform a search which will return multiple results
 - Click "Request article" on a title for which article requests can be
   submitted.
   - Confirm that the breadcrumbs menu looks and works correctly.
 - Click "Request article" on a title for which article requsts are not
   allowed.
   - Confirm that the message is correctly styled.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
---
 .../bootstrap/en/modules/opac-request-article.tt          | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt
index 69e452725c..25af23ee21 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt
@@ -13,6 +13,7 @@
 <div class="main">
     <ul class="breadcrumb">
         <li><a href="/cgi-bin/koha/opac-main.pl">Home</a> <span class="divider">&rsaquo;</span></li>
+        <li><a href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% biblio.biblionumber | uri %]">Details for: [% biblio.title | html %]</a> <span class="divider">&rsaquo;</span></li>
         <li><a href="#">Request article</a></li>
     </ul>
 
@@ -177,7 +178,10 @@
                 <input type="submit" class="btn" value="Place request" />
             </form>
         [% ELSE %]
-            No article requests can be made for this record.
+            <h1 class="title">[% biblio.title | html %]</h1>
+            <div class="alert alert-info">
+                No article requests can be made for this record.
+            </div>
         [% END %]
 
     </div> <!-- / .container -->
@@ -187,7 +191,6 @@
 
 [% BLOCK jsinclude %]
 <script>
-// <![CDATA[
     allow_submit = false;
     $('#place-article-request').on('submit', function( event ){
         if ( ! allow_submit ) {
@@ -220,6 +223,5 @@
             $('#place-article-request').submit();
         }
     });
-// ]]>
 </script>
 [% END %]
-- 
2.39.5