Bug 5327: Add unit test for ItemType.pm

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

unit test stub for Z3950.pm

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Create Unit Test for ImportBatch

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Merge remote branch 'kc/new/bug5075' into kcmaster

bug 5146: patron import files require header row

Fixed help text on this point as well as options for
supplying dates in the input file.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Bug 5327: Add basic unit tests to some C4 modules

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Bug 5327: Add basic unit tests to some C4 modules

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

create unit test files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Adding a simple test for Service.pm

At the advisement of the great Chris Cormack. (thanks for the lesson)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Bug 5322 - Added pwgen dependency

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Fix for Bug 5075 - Terms not highlighted w/ xslt on

- XSLT didn't contain the class markup which acts as a hook
  for the JavaScript highlighting system.
- Standard results page also contained a typo which
  prevented data other than title and author from
  being highlighted

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

bug 3211: fix some errors that crept into the cleanup

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Further fixes for Bug 3211, cataloging value plugin forms should be valid XHTML

- Adding page heading
- Adding "Cancel" link to close popup
- Correctly marking up <label> <input> pairs
- Correctly escaping JavaScript blocks
- General markup corrections

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

bug 5128: fix syntax errors in previous patch

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

update AUTHOR in Makefile.PL

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

DB revision 3.02.00.004 - general release of Koha 3.2.0

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Release notes for Koha 3.2.0

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

standardize name of ILS-DI:AuthorizedIPs syspref

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

updated to installation instructions

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

bug 3597: DelItemCheck now refuses to delete items in transit for holds

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

bug 3597: "delete all items" no longer deletes  checked out or waiting items

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

bug 5128: leave record.abs to French defaults

Compromise so that the majority of the English UNIMARC
framework can be accepted into 3.2.

Non-French UNIMARC users should observe the comment
at the bottom of record.abs.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Bug 5128 [3.2] Unimarc default for holdings. Written with French default

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Bug 4972 Fix table creations failing due to foreign key checks

create tables were failing with cryptic 1005 error from mysql
wrapped creation of aqbasketgroups and aqcontract in
FOREIGN_KEY_CHECKS=0 and FOREIGN_KEY_CHECKS=1

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

bug 3881: remove unused OpacPrivacy syspref

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

fixing various links to point to *.koha-community.org

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

bug 3756: remove disused system preference from database

This leaves a few system preferences displayed on the
local use tab in the syspref editor that should be displayed
elsewhere, but all of the ones left are actually in use.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Update changelog and build script in preperation for 3.2.0 release

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

bug 4176: remove references to unimplemented system preference MIME

The intended functionality of this system preference was never
implemented.  To avoid template changes prior to 3.2.0, put in
hard-coded string 'CSV' to (accurately) identify the type of
the output files in the affected reports.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

bug 3756: remove more references to disused sysprefs

OPACSubscriptionDisplay
OPACDisplayExtendedSubInfo
OAI-PMH:Set
OAI-PMH:Subset
ILS-DI:AuthorizedIPs
libraryAddress
kohaspsuggest
OrderPdfTemplate
marc
acquisitions

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

remove last vestiges of NOTMARC mode

MARC, the metadata exchange format for the 20th century!

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

bug 3756: start removing references to disused sysprefs

holdCancelLength
PINESISBN
sortbynonfiling
TemplateEncoding

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

remove two disused functions

html2marc and html2marcxml are not used, and html2marcxml
is the last user of the dead syspref TemplateEncoding

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

remove a couple duplicate lines

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

(bug 3536) fix homeorholdingbranch on return

this patch create a new systempreference "homeorholdingbranch"-like used only for returns.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
An additional edit was made to circ/returns.pl by Ian Walls of ByWater Solutions to force the dialog message for the return to
use the branch specified by the new HomeOrHoldingBranchReturn system preference, rather than always Homebranch.
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Bug 5303 Overdue notices subject is improperly encoded

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fixing a double count of a developer and adding a new one to the history

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Bug 4305 - prevent errors when handling invalid ISBN13 values

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Merge branch 'translation' of git://git.workbuffer.org/git/koha into to-push

Translations

Bug 4472 Fix &nbsp; handling for UNIMARC intranet XSL

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

bug 3164: fix OPAC holds in SingleBranchMode

Account for case where no branch is explicitly supplied.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Add one new speech, bugfix a few other history lines

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

(MT #3697) Fixed GetAuthorityRecords

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

[MT3696] Fixed ILSDI GetAvailability call
(cherry picked from commit 96552d64727dc6fc2525cc9c0c6ece0c718b999d)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

(MT #3698) Fixed ILSDI GetRecords
(cherry picked from commit f69061357a75a5e024fe6379a1a48f8755a2b6db)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

remove scratch files from the it-IT SQL files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

add new lenny dependency libmodule-install-perl to the apt-get-debian-lenny.sh script

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

add Italian installer SQL to test cases

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Italian installer SQL

Created by Zeno Tajoli <tajoli@cilea.it>.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

fix step to install Indexdata apt key

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Updates to INSTALL.debian documentation for 3.2.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Adding a temporary workaround to keep template tests from borking on very large templates

NOTE: This should be properly fixed at some point in 3.4

This may help:

http://www.perlmonks.org/?node_id=150748

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Bug 5288 - Update package dependencies, control source details

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

mark 3.2.0 release candidate - DBrev 3.01.00.999

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

defer rotating collections

Disabling rotating collections for 3.2.0 release; after more testing,
candidate for 3.4 as well as backport into 3.2.1.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

translator hack to avoid failure on opac-opensearch.tmpl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

further correction to the invocation of unzip

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Tighten system call to unzip

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

add explicit type to <input> elements missing it

Quells a warning from xt/author/translatable-templates.t

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

bug 4472: in a hackish fashion, quiet warnings about DOCTYPE in the XSLT

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Merge branch 'translation' of git://git.workbuffer.org/git/koha into master

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Updated spanish files

Another fix for Bug 2704, 440 Display Issues

Removing the check for 490 @ind1=0 since the
alternative 8xx tag will not display anyway

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Merge remote branch 'koha-fbc/k_bug_5284' into master

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Bug 5284 - Generic report covering various problems with the labels/patron card tests

This patch removes a very incomplete test script which was really not even formed into
a test routine.

Note: In all probability, the labels tests could be adapted to test patroncards as well.

Merge remote branch 'koha-fbc/k_bug_5284' into master

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Bug 5284 - Generic report covering various problems with the labels/patron card tests

This patch fixes the C4::Labels::Template tests

Bug 5284 - Generic report covering various problems with the labels/patron card tests

This patch fixes the C4::Labels::Profile tests

Bug 4472 Fix how &nbsp; are injected into XSL files

tmpl_process is patched to handle properly specific XML directives.
UNIMARC XSL files are modified to gain knowledge of HTML &nbsp; entity
which isn't the case by default. It may be necessary to do the same
thing for MARC21 XSL.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Bug 5284 - Generic report covering various problems with the labels/patron card tests

This patch fixes the C4::Labels::Layout tests

Followup to Bug 4305: multiple ISBNS in biblioitems.isbn breaks patron

This patch adds a scrub for ' | ' when the ISBN comes from the
biblioitems table, in the event that Koha has attempted to store
multiple ISBNs in the field.  The ISBN presented to Business::ISBN will
now be something it can handle.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

fix invalid invocation of GetBranches in test case

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Bug 5284 - Generic report covering various problems with the labels/patron card tests

This patch fixes the C4::Labels::Batch tests

Bug 5013: Advanced patron search category pull down broken

The pull down for category in patron's advanced search was only showing any and no patron categories.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

more test case fixes

SQLHelper.t - clean up after itself better
Context.t - fix reporting of test plan

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

cleanup of DB-dependent fund test cases

* remove test that was adding a second active budget period,
  which was throwing off later tests
* updated to reflect current API

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

fix typo/thinko in list test

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

various improvements to t/db_dependent/VirtualShelves.t

* updated to reflect recent (and old) changes to the API
* corrected test plan
* adopted Test::More
* correctly handle and test functionality to not add duplicate
  bibs to a list

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

removed AddToShelfFromBiblio from C4::VirtualShelves

Back in the day, lists could contain item records instead or in addition
to bibs, but that hasn't been the case for a while.  Therefore, removed
AddToShelfFromBiblio, which does exactly the same thing that AddToShelf does.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

fix test plan and false test errors in Search.t

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

fix test plan for SQLHelper.t

Also removed incorrect comments about test case numbers - we should
just let Test::More number them.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix for Bug 2377 - Review tags: format date according to system preference

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Merge branch 'test_cases' of /home/koha/koha1/dev into to-push

fix typo in INSTALL.debian

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

use Test::More for t/Koha.t

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix for Bug 5100, Incorrect link to System Preferences

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix for Bug 5156 - JavaScript error when adding list

JavaScript referenced nonexistent form name

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

fixes bug 4385

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Bug 5264 (Retain additional bibliographic subfields when merging authorities) [for master only]

The current code in AuthoritiesMarc.pm rewrites all subfields from the report
tag in the authority record to fields in related bibliographic records when
merging authorities. Additional subfields in the biblio records (e.g. relator
code or term) are lost in the process.

This patch retains the original algorithm but restores the additional subfields
from the original biblio record when rewriting the linked marc fields.

The problem also exists in 3.0. Two separate patches have been submitted.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fixing non placeholder sql in UpdateGuarantees

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Bug 5089: Add German translation of borrowerRelationship and BorrowersTitles values

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix for Bug 5093 - JavaScript error in IE8 when choosing authority record

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Bug 5092: No results when searching by LC Call Number: in Z39.50 Server

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix for Bug 2947, value_builder scripts using authnotrequired

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Bug 3630 Impossible to perform Scan Indexes search

This is a quick fix. The way scan indexes performs should be improved in
3.4. There are several issues:

  - No paging
  - The interface is the same as for biblio records search result and so
    is unusable: for example you have a button to place a hold or you
    can sort by Popularity which is irrelevant for index terms.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Avoid to add a warning in log

... each time GetMemberDetails function is called

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix for Bug 4849 - Cannot delete records from Labeled MARC view

The template checks for a "count" variable (item count) to see
whether it should allow deletion of the biblio record. For some
reason labeledMARCdetail.pl hard-coded this as 1, which meant
the template always thought was 1 item.

This patch also adds an item count check on the display of
"Delete all items," disabling it if there are no items.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Bug 5054 - allow the resulting .deb location to be specified

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Bug 5139 - packages now do email and other cron jobs

By default the packages now set up the cron jobs to handle things like
overdues and email etc. By default, email is off, 'koha-email-enable'
and 'koha-email-disable' can manage this.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>