From 158092f283acebcf08f792882ae50be6ad79d761 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Tue, 6 Aug 2024 17:09:53 +0000
Subject: [PATCH] Bug 37578: Remove the Charges tab from checkout and patron
 details

This patch removes the "Charges" tab from the include file which is used
by the circulation and patron details templates. Information about
charges and credits is already shown at the top of these pages under the
"Attention" heading.

This tab is already hidden on the checkout page
because the script doesn't provide the data to display.

To test, apply the patch locate a patron with charges.

- Check out to the patron. As before, you should see under the
  "Attention" heading at the top, "Charges: Patron has outstanding
  charges of..."
- There should be no "Charges" tab below in the section showing tabs for
  checkouts, holds, etc.
- Check the same details on the patron detai page.
- A patron with credits should be displayed similarly.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Nicolas Hunstein <nicolas.hunstein@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 .../prog/en/includes/patron-detail-tabs.inc        | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc
index eebb3d1111..739c87be8e 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc
@@ -13,12 +13,6 @@
             [% END %]
         [% END %]
 
-        [% IF ( fines ) %]
-            [% WRAPPER tab_item tabname= "finesandcharges" %]
-                <span>Charges ([% fines | $Price %])</span>
-            [% END %]
-        [% END %]
-
         [% IF ( guarantees_fines ) %]
             [% WRAPPER tab_item tabname= "guarantees_finesandcharges" %]
                 <span>Guarantees' charges ([% guarantees_fines | $Price %])</span>
@@ -99,14 +93,6 @@
             [% INCLUDE "relatives-issues-table.inc" %]
         [% END # /tab_panel# %]
 
-        [% WRAPPER tab_panel tabname="finesandcharges" %]
-            [% IF ( fines ) %]
-                <p>Total due: [% fines | $Price %]</p>
-            [% ELSE %]
-                <p>No outstanding charges</p>
-            [% END %]
-        [% END # /tab_panel# %]
-
         [% IF ( guarantees_fines ) %]
             [% WRAPPER tab_panel tabname="guarantees_finesandcharges" %]
                 <table id="tguaranteesfines">
-- 
2.39.5