From 5b8f125c824312b3540a0c7505d63314589a6d9f Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Wed, 15 Dec 2021 15:44:06 +0000 Subject: [PATCH] Bug 29702: Fetch group libraries in a single call The current code gets all group members, then loops through and fetches the library if there is a branchcode, or recursively calls itself if a group. This slows down performance. We can utilize the 'libraries' method to get all child libraries at once, then make a check for child groups separately To recreate: 1 - Add 100 items to a biblio 2 - Define a library group as a hold group 3 - Add all libraries to the group 4 - Set 'Default checkout, hold and return policy'->'Hold pickup library match' = 'Any library' 5 - place a hold on the record and note load time after patron is selected 6 - Set 'Default checkout, hold and return policy'->'Hold pickup library match' = 'Patrons hold group' 7 - place a hold, note longer load time after patron selection 8 - Apply patch 9 - note improvement 10 - prove -v t/db_dependent/Koha/Libraries.t Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi Signed-off-by: Fridolin Somers Signed-off-by: Kyle M Hall --- Koha/Library/Group.pm | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/Koha/Library/Group.pm b/Koha/Library/Group.pm index aaf68530d5..ea9ed134eb 100644 --- a/Koha/Library/Group.pm +++ b/Koha/Library/Group.pm @@ -144,14 +144,10 @@ sub all_libraries { my @libraries; - my @children = $self->children; + push (@libraries, $self->libraries); + my @children = $self->children->search({ branchcode => undef }); foreach my $c (@children) { - if ( $c->branchcode ) { - push( @libraries, $c->library ); - } - else { - push( @libraries, $c->all_libraries ); - } + push( @libraries, $c->all_libraries ); } my %seen; -- 2.39.5